Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support symbolic dimension in Scan subgraph outputs #22

Merged

Commits on Nov 24, 2018

  1. Handle the Scan subgraph producing outputs with a symbolic dimension.

    If the output has a symbolic dimension
      * Infer the shape if it is a loop state variable as we have the input value, and the shape from the subgraph output must match
      * Use a temporary MLValue for the first subgraph execution if it is a subgraph output with a symbolic dimension.
        * After the first execution make the overall output shape concrete and allocate the full output buffer.
        * Use slices of the full output buffer for all other subgraph executions to avoid copies.
    
    Add unit test to validate.
    skottmckay committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    5d3992f View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2018

  1. Update some comments

    skottmckay committed Nov 25, 2018
    Configuration menu
    Copy the full SHA
    eef36d2 View commit details
    Browse the repository at this point in the history
  2. Update comments

    skottmckay committed Nov 25, 2018
    Configuration menu
    Copy the full SHA
    720aca5 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2018

  1. Configuration menu
    Copy the full SHA
    eef4db3 View commit details
    Browse the repository at this point in the history
  2. Merge

    skottmckay committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    3ccb087 View commit details
    Browse the repository at this point in the history