Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilora docs #22865

Open
wants to merge 7 commits into
base: gh-pages
Choose a base branch
from
Open

Multilora docs #22865

wants to merge 7 commits into from

Conversation

@natke natke changed the title Multilora API docs Multilora docs Nov 18, 2024

## Schema

The schema for the file is as follows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we instead point users to the schema inside the repo so we don't need to copy the contents every time there is a change?
https://github.com/microsoft/onnxruntime/blob/main/onnxruntime/lora/adapter_format/adapter_schema.fbs


#### Return value

`OgaResult` containing an error message if the adapter failed to unload. This can occur if the method is called with an adapter that is not already loaded.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`OgaResult` containing an error message if the adapter failed to unload. This can occur if the method is called with an adapter that is not already loaded.
`OgaResult` containing an error message if the adapter failed to unload. This can occur if the method is called with an adapter that is not already loaded or has been marked active by a `OgaGenerator` still in use.

This example is shown in Python, but you can also use the C/C++ API, the C# API, and the Java API (_coming soon!_)

```python
import onnxruntime_genai as og
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is ok, shall we update model-qa.py in onnxruntime-genai to add support for loading adapters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants