This repository has been archived by the owner on May 6, 2022. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #3 from seecrypt/fix-comment-backslashes
Fixes builds where environment variable has backslashes
- Loading branch information
c20688d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khouzam, would be really nice if you guys can fix this issue nodejs/node#478 in openssl source for VS2015.
//cc @rvagg
c20688d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can take a look at this, I'm actually working on VS 2015 support but haven't hit this particular issue. Can you give me more details about your setup and how you build?
c20688d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khouzam just this tiny modification in e_os.h: https://github.com/iojs/io.js/pull/478/files#diff-1 from memory it was just a link problem for openssl-cli.exe pointing to a missing
__iob_func
, ensuring that block wasn't invoked for 2015 does the trick