Update license, add CHANGELOG, make changes to fit OT, add CODEOWNERS #4
Conversation
| @@ -0,0 +1,5 @@ | |||
| # Code owners file. | |||
There was a problem hiding this comment.
We don't have Code owners file in any ApplicationInsights repo, why adding it here?
There was a problem hiding this comment.
This is not an ApplicationInsights repo.
There was a problem hiding this comment.
I know that, I want to know why you are adding this here?, what is the purpose of this file?, how can this be useful? ,etc. It feels this is irrelevant in a Microsoft owned repo but maybe I'm wrong
There was a problem hiding this comment.
The purpose of this file is so that any new issues will have the aliases in the CODEOWNERS file automatically tagged to review the PRs. It is not a REPO specific concept but a GITHUB concept.
azure_monitor/CHANGELOG.md
Outdated
| ## Unreleased | ||
|
|
||
| ## 0.1a.0 | ||
| Released 2019-11-05 |
There was a problem hiding this comment.
I'm planning on releasing today.
There was a problem hiding this comment.
Actually on second thought, I should change this to unreleased until I actually release it.
According to CELA, it is safe to change the Apache license to the MIT license when moving from OT to Microsoft repo because all the changes were made by Microsoft employees.