Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Adding docs #60

Merged
merged 5 commits into from
Mar 24, 2020
Merged

Adding docs #60

merged 5 commits into from
Mar 24, 2020

Conversation

hectorhdzg
Copy link
Member

Fixes #58

@hectorhdzg hectorhdzg requested a review from lzchen as a code owner March 23, 2020 19:56
@codecov-io
Copy link

codecov-io commented Mar 23, 2020

Codecov Report

Merging #60 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   98.39%   98.40%           
=======================================
  Files          13       13           
  Lines         749      751    +2     
  Branches       95       96    +1     
=======================================
+ Hits          737      739    +2     
  Misses          9        9           
  Partials        3        3           
Impacted Files Coverage Δ
...itor/src/azure_monitor/auto_collection/__init__.py 100.00% <ø> (ø)
...zure_monitor/auto_collection/dependency_metrics.py 100.00% <ø> (ø)
...ure_monitor/auto_collection/performance_metrics.py 100.00% <ø> (ø)
...c/azure_monitor/auto_collection/request_metrics.py 100.00% <ø> (ø)
azure_monitor/src/azure_monitor/export/__init__.py 100.00% <100.00%> (ø)
...nitor/src/azure_monitor/export/metrics/__init__.py 96.00% <100.00%> (ø)
...monitor/src/azure_monitor/export/trace/__init__.py 100.00% <100.00%> (ø)
azure_monitor/src/azure_monitor/options.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5273d4...0b73ae4. Read the comment docs.

tox.ini Outdated Show resolved Hide resolved
@hectorhdzg
Copy link
Member Author

"""Azure Monitor base exporter for OpenTelemetry.

Args:
options: Configuration options for the exporter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well.

Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment. Otherwise looks good!

@hectorhdzg hectorhdzg merged commit 3c9f024 into microsoft:master Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate code documentation
3 participants