This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 98.39% 98.40%
=======================================
Files 13 13
Lines 749 751 +2
Branches 95 96 +1
=======================================
+ Hits 737 739 +2
Misses 9 9
Partials 3 3
Continue to review full report at Codecov.
|
lzchen
reviewed
Mar 23, 2020
lzchen
reviewed
Mar 23, 2020
lzchen
reviewed
Mar 23, 2020
azure_monitor/src/azure_monitor/auto_collection/performance_metrics.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Mar 23, 2020
lzchen
reviewed
Mar 24, 2020
lzchen
reviewed
Mar 24, 2020
lzchen
reviewed
Mar 24, 2020
"""Azure Monitor base exporter for OpenTelemetry. | ||
|
||
Args: | ||
options: Configuration options for the exporter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well.
lzchen
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment. Otherwise looks good!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58