Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Refactor to opentelemetry-azure-monitor-python #64

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Mar 25, 2020

List of changes:

  1. Move auto_collection under sdk folder. This is reflected in code, README, examples and docs
  2. Change github repo name (already done) -> user's might need to update their remote repo urls, TravisCI points to new repo name
  3. Changed Github team new for maintainers (already done)
  4. Add test for supress_instrumentation

TODO:
Upload new package to PyPi
Deprecate old package by pointing to new package
Update versions and CHANGELOGs on release to beta
Update ALL READMEs to reflect new package + badges

@lzchen lzchen requested a review from hectorhdzg as a code owner March 25, 2020 20:44
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-Authored-By: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
@codecov-io
Copy link

codecov-io commented Mar 26, 2020

Codecov Report

Merging #64 into master will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   98.27%   98.67%   +0.39%     
==========================================
  Files          13       14       +1     
  Lines         753      753              
  Branches       97       97              
==========================================
+ Hits          740      743       +3     
+ Misses          9        8       -1     
+ Partials        4        2       -2     
Impacted Files Coverage Δ
..._monitor/sdk/auto_collection/dependency_metrics.py 100.00% <ø> (ø)
...monitor/sdk/auto_collection/performance_metrics.py 100.00% <ø> (ø)
...ure_monitor/sdk/auto_collection/request_metrics.py 100.00% <ø> (ø)
azure_monitor/src/azure_monitor/__init__.py 100.00% <100.00%> (ø)
azure_monitor/src/azure_monitor/sdk/__init__.py 100.00% <100.00%> (ø)
.../src/azure_monitor/sdk/auto_collection/__init__.py 100.00% <100.00%> (ø)
...nitor/src/azure_monitor/export/metrics/__init__.py 100.00% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f6073e...d6aa639. Read the comment docs.

@lzchen lzchen merged commit e557a9a into microsoft:master Mar 26, 2020
@lzchen lzchen deleted the name branch March 26, 2020 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants