This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 549
[VC update] rest-server #1831
Merged
Merged
[VC update] rest-server #1831
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a37b479
change scheduler storage to zookeeper
mzmssg 249a4fe
add queue update
mzmssg 8035e94
fix
mzmssg 672a2c0
add vc update api
mzmssg ab52288
add yarn health check, refine error
mzmssg ac39a65
add api doc
mzmssg 33f5f55
refine api doc
mzmssg 022770a
refine api doc
mzmssg ff8151a
update yarn response
mzmssg 1707e5b
add unit test
mzmssg 12141c5
unit test
mzmssg 42c17db
merge branch vc_update
mzmssg 9714940
replace parseint with math.round, fix unit test
mzmssg 88037b2
replace mathjs with build-in Math
mzmssg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// Copyright (c) Microsoft Corporation | ||
// All rights reserved. | ||
// | ||
// MIT License | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated | ||
// documentation files (the "Software"), to deal in the Software without restriction, including without limitation | ||
// the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and | ||
// to permit persons to whom the Software is furnished to do so, subject to the following conditions: | ||
// The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED *AS IS*, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING | ||
// BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND | ||
// NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
||
// module dependencies | ||
const Joi = require('joi'); | ||
|
||
// define the input schema for the 'update vc' api | ||
const vcPutInputSchema = Joi.object().keys({ | ||
vcCapacity: Joi.number() | ||
.integer() | ||
.min(0) | ||
.max(100) | ||
.required(), | ||
}).required(); | ||
|
||
// define the input schema for the 'put vc status' api | ||
const vcStatusPutInputSchema = Joi.object().keys({ | ||
vcStatus: Joi.string() | ||
.valid(['stopped', 'running']) | ||
.required(), | ||
}).required(); | ||
|
||
// module exports | ||
module.exports = { | ||
vcPutInputSchema: vcPutInputSchema, | ||
vcStatusPutInputSchema: vcStatusPutInputSchema, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fanyangCS
Shall we add a yarn dependency to rest server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question. the desired behavior is: if yarn is available, it works. if yarn is unavailable, the system says it doesn't support the feature yet.
In reply to: 239478932 [](ancestors = 239478932)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gerhut @fanyangCS
I will move the validation somewhere to remove the dependency. But I think we need clarify
vc
firstly, it will affect our API design.If we consider
vc
as the same concept ofhadoop queue
, moving the check tovc
related API sounds reasonable, because only yarn provider this feature.But if
vc
is designed as a abstract interface,hadoop queue
is only one implementation. I think we need refactor our vc structure, to support other implementation. At least, some API coupling withhadoop queue
shoulded be add to our doc.