This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
vc update #1974
Merged
vc update #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xwzheng1020
commented
Jan 5, 2019
xwzheng1020
commented
- add new ui for virtual cluster action(add, delete, change status and update capacity)
- only admin-user has these privileges
add entrypoint=""
|
|
|
Please fix all lint errors first. |
|
@weixingzhang , can you attach a snapshot of the UI for reference? |
|
@fanyangCS |
Gerhut
suggested changes
Jan 8, 2019
| <div class="modal-vc-content"> | ||
| <div class="form-group edit-group"> | ||
| <label for="editName" class="edit-group-item">Name</label> | ||
| <input id="editName" name="nameEdit" class="add-vc-fild form-control" placeholder="Virtual Cluster Name" readonly=true> |
There was a problem hiding this comment.
no =true needed in readonly attribute
There was a problem hiding this comment.
Should this field nameEdit be readonly? I didn't find that the PUT virtualCluster API includes vc name.
There was a problem hiding this comment.
It is better to set it readonly.
Gerhut
approved these changes
Jan 9, 2019
mzmssg
added a commit
that referenced
this pull request
Jan 10, 2019
* VC update API doc (#1816) * refine api doc * refine doc * refine * refine * [VC update] rest-server (#1831) * change scheduler storage to zookeeper * add queue update * fix * add vc update api * add yarn health check, refine error * add api doc * refine api doc * refine api doc * update yarn response * add unit test * unit test * replace parseint with math.round, fix unit test * replace mathjs with build-in Math * vc update (#1974) * Update yarnContainerScript.mustache add entrypoint="" * add design for vc update * refine design of vc update * add description of /api/v1/:username/virtualClusters * remove design of vc_update to dir of webportal * refine design of vc * VC function development * vc style modification * vc list style modification * Modify the prompt * repair bug * remove design of vc_update and refine annotation * refine var name * Change eslint error * Optimize the code according to pr * Modified read-only
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.