-
Notifications
You must be signed in to change notification settings - Fork 549
[Cluster Object Model] Generate necessary service config based on cluster type #4036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3437 uses config/service.yaml
and config/service.k8s.yaml
to differ different cluster types.
If you add a new field in config/service.yaml
, you need to revert changes in #3437 first.
The name openpai_parser_type
in config/service.yaml
is also confusing, could you use another name like service_type
?
I wil change it in anther PR |
#4038 Please review this PR first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openpai_parser_type
is confusing, maybe change to another name, e.g. service-type
?
Done |
Design 3 parse type: yarn, k8s, common.
If the cluster-type is yarn, the configuration of yarn and common will be generated.
If the cluster-type is k8s, the configuration of k8s and common will be genereated.