Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

[Cluster Object Model] Generate necessary service config based on cluster type #4036

Merged
merged 20 commits into from
Jan 2, 2020

Conversation

ydye
Copy link
Contributor

@ydye ydye commented Dec 19, 2019

Design 3 parse type: yarn, k8s, common.
If the cluster-type is yarn, the configuration of yarn and common will be generated.
If the cluster-type is k8s, the configuration of k8s and common will be genereated.

Copy link
Member

@abuccts abuccts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3437 uses config/service.yaml and config/service.k8s.yaml to differ different cluster types.
If you add a new field in config/service.yaml, you need to revert changes in #3437 first.

The name openpai_parser_type in config/service.yaml is also confusing, could you use another name like service_type?

@ydye
Copy link
Contributor Author

ydye commented Dec 19, 2019

#3437 uses config/service.yaml and config/service.k8s.yaml to differ different cluster types.
If you add a new field in config/service.yaml, you need to revert changes in #3437 first.

The name openpai_parser_type in config/service.yaml is also confusing, could you use another name like service_type?

I wil change it in anther PR

@ydye
Copy link
Contributor Author

ydye commented Dec 19, 2019

#3437 uses config/service.yaml and config/service.k8s.yaml to differ different cluster types.
If you add a new field in config/service.yaml, you need to revert changes in #3437 first.

The name openpai_parser_type in config/service.yaml is also confusing, could you use another name like service_type?

#4038 Please review this PR first.

Copy link
Member

@abuccts abuccts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openpai_parser_type is confusing, maybe change to another name, e.g. service-type?

src/rest-server/deploy/stop.sh Show resolved Hide resolved
@ydye
Copy link
Contributor Author

ydye commented Dec 26, 2019

openpai_parser_type is confusing, maybe change to another name, e.g. service-type?

Done

@ydye ydye merged commit d659ffd into master Jan 2, 2020
@ydye ydye deleted the yuye/k8s-com branch January 14, 2020 07:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants