This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
[Rest Server] Update job name encoding method #4069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update job name encoding method, use md5 hash instead. Query job by k8s label selector. Resolve job name related issues in #3935.
54 tasks
|
why not directly use md5 name to lookup, it is more efficient than label? |
|
And we haven't even release pure k8s image, compatibility is not so important than doing the right thing. |
Drop legacy jobs compatibility.
abuccts
force-pushed
the
xiongyf/update-job-name-encode
branch
from
dbe7261 to
beafbcd
Compare
sunqinzheng
approved these changes
Dec 27, 2019
yqwang-ms
approved these changes
Dec 27, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update job name encoding method, use md5 hash instead.
Query job by k8s label selector.
Resolve job name related issues in #3935.