Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

add new eslint rules and fix errors #4823

Merged
merged 7 commits into from
Aug 25, 2020
Merged

add new eslint rules and fix errors #4823

merged 7 commits into from
Aug 25, 2020

Conversation

debuggy
Copy link
Contributor

@debuggy debuggy commented Aug 20, 2020

  1. Currently just add src folder in linter rules (not including test cause some unhandled issues)
  2. Use standard + prettier eslint plugins, some important rules:
  semi: true,
  // Trailing commas help with git merging and conflict resolution
  trailingComma: 'all',
  // Use single quote in all files. https://github.com/prettier/prettier/issues/1080#issuecomment-390363232
  singleQuote: true
  1. Need a overall api test to ensure the compatibility
  2. Update nodejs version to dubnium (node 10) cause some packages do not support node 8

@debuggy debuggy requested review from hzy46, abuccts and yiyione August 20, 2020 06:19
@coveralls
Copy link

coveralls commented Aug 20, 2020

Coverage Status

Coverage increased (+0.009%) to 34.837% when pulling adff80f on linter into ff57442 on master.

@scarlett2018 scarlett2018 mentioned this pull request Aug 20, 2020
39 tasks
@debuggy debuggy merged commit d61a971 into master Aug 25, 2020
@yiyione yiyione mentioned this pull request Aug 26, 2020
30 tasks
@scarlett2018 scarlett2018 mentioned this pull request Sep 10, 2020
5 tasks
@yiyione yiyione deleted the linter branch November 23, 2020 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants