Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

use checkAdmin middleware #5051

Merged
merged 1 commit into from
Nov 4, 2020
Merged

use checkAdmin middleware #5051

merged 1 commit into from
Nov 4, 2020

Conversation

suiguoxin
Copy link
Member

@suiguoxin suiguoxin commented Nov 3, 2020 •
edited
Loading

  • refactor with common middleware to avoid code duplication
  • fix issues in getGroupUserList and createGroup function. The created error was not thrown immediately so the following code will be executed even when the auth check doesn't pass.

@coveralls
Copy link

coveralls commented Nov 3, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 34.374% when pulling f53eade on suiguoxin:check-admin into 730a23c on microsoft:master.

@suiguoxin suiguoxin requested a review from abuccts November 3, 2020 10:00
@suiguoxin suiguoxin merged commit ff1201a into microsoft:master Nov 4, 2020
@suiguoxin suiguoxin deleted the check-admin branch November 4, 2020 02:58
@suiguoxin suiguoxin mentioned this pull request Nov 20, 2020
Closed
38 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abuccts abuccts abuccts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suiguoxin @coveralls @abuccts