Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

docker cache deploy #5290

Merged
merged 80 commits into from
Feb 22, 2021

Conversation

SwordFaith
Copy link
Contributor

close #5219

@@ -9,6 +9,61 @@
logger = get_logger(__name__)


def get_docker_cache_config_and_mirrors(layout, cluster_config):
"""
generate hived config from layout.yaml and config.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments are incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@@ -9,6 +9,61 @@
logger = get_logger(__name__)


def get_docker_cache_config_and_mirrors(layout, cluster_config):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function can be removed. During installation, using config.yml + services-configuration.yaml.template is enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@@ -233,6 +233,61 @@ def get_hived_config(layout, cluster_config):
return { "skus": skus }


def get_docker_cache_config_and_mirrors(layout, cluster_config):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function can be removed. During installation, using config.yml + services-configuration.yaml.template is enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

service_port: 5000
service_nodeport: 30500
remote_url: https://registry-1.docker.io
registry-htpasswd: dGVzdDokMnkkMDUkRUZiaWphaHovMHl4UC5xMFk1VW52TzljU2hHMThCRzM3QzBHNFhoRmFtTXdTUXdQLjBqQi4KCg==
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a default passwd? What is the exact meaning of this string?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's test test processed by htpasswd tool and base64 encoded, commented out in new commit.

@@ -20,6 +20,7 @@ cluster-type:

prerequisite:
- cluster-configuration
- drivers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this.

You can ignore services with cluster-type: yarn because they are not supported now.

@@ -20,6 +20,7 @@ cluster-type:

prerequisite:
- cluster-configuration
- docker-cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can ignore services with cluster-type: yarn because they are not supported now.

- name: run add_docker_cache_config.py script to add docker cache config
ansible.builtin.command:
argv:
- sudo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice there's "become: true" already. So you can remove this sudo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will update this

@SwordFaith SwordFaith merged commit 0b50364 into microsoft:master Feb 22, 2021
@SwordFaith SwordFaith deleted the swordfaith/docker-cache-deploy branch February 22, 2021 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerhub Rate Limiting
6 participants