-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing of new GC events #1758
Parsing of new GC events #1758
Conversation
fa7bd50
to
bd9f54c
Compare
bd9f54c
to
6539eb1
Compare
2f2d465
to
6c0019c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cshung, a few comments, but overall, looks good.
Similarly, Times is an array, how exactly do we do that? In reply to: 1370367894 Refers to: src/TraceEvent/Parsers/ClrTraceEventParser.cs:6977 in 6c0019c. [](commit_id = 6c0019c, deletion_comment = False) |
6c0019c
to
70d63ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This change performs the parsing of the new events introduced in dotnet/runtime#55888.
At a high level, here are the code changes:
GenAware
trace parsing more consistent with the manifest, in particular, I collapsed theGenAwareBeginTraceData
andGenAwareEndTraceData
into a single classGenAwareTemplateTraceData
. These two classes are identical anyway. I also renamed the eventGCGenAwareStart
toGCGenAwareBegin
to be consistent with the manifest as well.Introduce the new
GCLOHCompact
,GCFitBucketInfo
, andGCSettingsRundown
events. These events are newly introduced in .NET 6.Parse the new V4
GCAllocationTick
event that includes a new field namedObjectSize
Parse the new V4
GCGlobalHeapHistory
event that includes an array of timestamps.Add the missed
PinnedObjectHeap
enum value for theCreateSegment
event.Add the GC keyword to the default rundown keywords.
In addition to the events exposed on
ClrTraceEventParser
, we also expose the data throughTraceGarbageCollector
as public property andTraceGC
as public fields (to be consistent with other fields).This info is also reflected in the raw XML for the
GCStat
page.