Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a formatError exception when parsing some Linux traces. #890

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

vancem
Copy link
Contributor

@vancem vancem commented Mar 6, 2019

This was caused by a trace with an empty process name. Fixed to be resilient to that.

Also made the code clearer while I was in there.

@codecov-io
Copy link

Codecov Report

Merging #890 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
- Coverage   17.48%   17.47%   -0.01%     
==========================================
  Files         228      228              
  Lines      139263   139271       +8     
  Branches    12334    12336       +2     
==========================================
- Hits        24353    24341      -12     
- Misses     113967   113985      +18     
- Partials      943      945       +2
Flag Coverage Δ
#2017 17.47% <33.33%> (-0.01%) ⬇️
#Debug 17.47% <33.33%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...w/OtherSources/Linux/LinuxPerfScriptEventParser.cs 75.85% <33.33%> (-1.17%) ⬇️
src/PerfView/Utilities/FastStream.cs 45.85% <0%> (-2.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705cc73...f11500b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants