fix: migrate to new waitForEventInfo handling #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
bugfix/wait-event-infra
branch
from
e8648ae
to
42d786a
Compare
| ) | ||
|
|
||
| def _wait_for_event_info_after(self, wait_id: str, error: Exception = None) -> None: | ||
| try: |
There was a problem hiding this comment.
When / how does this raise an Exception here that you need try here ?
There was a problem hiding this comment.
The page or Playwright can be closed.
mxschmitt
force-pushed
the
bugfix/wait-event-infra
branch
from
892568b
to
ac6847b
Compare
mxschmitt
force-pushed
the
bugfix/wait-event-infra
branch
from
ac6847b
to
d062652
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #820
Fixes #823