Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] expose textContent, innerText, getAttribute on page/frame #2143

Closed
pavelfeldman opened this issue May 7, 2020 · 0 comments · Fixed by #2235
Closed

[Feature] expose textContent, innerText, getAttribute on page/frame #2143

pavelfeldman opened this issue May 7, 2020 · 0 comments · Fixed by #2235

Comments

@pavelfeldman
Copy link
Member

Missing these convenience methods.
aslushnikov added a commit to aslushnikov/playwright that referenced this issue May 14, 2020
@aslushnikov
feat: add page convenience methods for textContent and getAttribute
e71b13b 
This patch adds:
- `page.innerText()` / `frame.innerText()`
- `page.innerHTML()` / `frame.innerHTML()`
- `page.textContent()` / `frame.textContent()`
- `page.getAttribute()` / `frame.getAttribute()`

Fixes microsoft#2143
@aslushnikov aslushnikov mentioned this issue May 14, 2020
Merged
aslushnikov added a commit that referenced this issue May 19, 2020
@aslushnikov
feat: add page convenience methods for textContent and getAttribute (#…
f24696b 
…2235)

This patch adds:
- `page.innerText()` / `frame.innerText()`
- `page.innerHTML()` / `frame.innerHTML()`
- `page.textContent()` / `frame.textContent()`
- `page.getAttribute()` / `frame.getAttribute()`

Fixes #2143
dcalhoun added a commit to Automattic/studio that referenced this issue May 17, 2024
@dcalhoun
test: Delete site E2E case supports native dialogs
545cbb5 
Playwright lacks support for interacting with native dialogs, so we mock
the dialog module to simulate the user clicking the "Delete site"
confirmation button with "Delete site files from my computer" checked.

See: microsoft/playwright#2143
See: microsoft/playwright#8278 (comment)
dcalhoun added a commit to Automattic/studio that referenced this issue May 29, 2024
@dcalhoun
test: Delete site E2E case supports native dialogs
97a822e 
Playwright lacks support for interacting with native dialogs, so we mock
the dialog module to simulate the user clicking the "Delete site"
confirmation button with "Delete site files from my computer" checked.

See: microsoft/playwright#2143
See: microsoft/playwright#8278 (comment)
wojtekn pushed a commit to Automattic/studio that referenced this issue May 30, 2024
@dcalhoun
test: Delete site E2E case supports native dialogs (#186)
cd5ff09 
* test: Delete site E2E case supports native dialogs

Playwright lacks support for interacting with native dialogs, so we mock
the dialog module to simulate the user clicking the "Delete site"
confirmation button with "Delete site files from my computer" checked.

See: microsoft/playwright#2143
See: microsoft/playwright#8278 (comment)

* test: Update Onboarding continue button label text

* refactor: Fix typo

* test: Improve stability of onboarding interactions

Combine `toBeVisible`'s interval with the ability to assert the precence
of one of multiple elements to ensure the UI is ready before
conditionally proceeding with the onboarding steps. This reduces the
likelihood that the UI is not ready when the test interactions begin and
also allows the Sites tests to succeed regardless of whether sites
already exists when the tests begin to run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add page convenience methods for textContent and getAttribute aslushnikov/playwright
1 participant
@pavelfeldman