Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] --list doesnt respect only/fixme/skip #28709

Closed
dimkin-eu opened this issue Dec 19, 2023 · 4 comments · Fixed by #28721
Closed

[BUG] --list doesnt respect only/fixme/skip #28709

dimkin-eu opened this issue Dec 19, 2023 · 4 comments · Fixed by #28721

Comments

@dimkin-eu
Copy link

System info

  • Playwright Version: [v1.40.1]

Source code

[We will only be able to work on the issues that we can reproduce.]

[Please provide a self-contained example in a form of a snippet, archive or a repository.]

[Repro scenario can't be large or have external dependencies.]

Steps

  • [Run the test]
    playwright test --list

Expected

--list should return only tests to be executed

  • tests marked with fixme/skip shouldn't be shown
    or
  • only tests marked with only must be shown
Total: 1 tests in 1 file

Actual

returns all tests

Total: 2 tests in 1 file
import {test} from '@playwright/test'

test.describe("describe", () => {
    test("short spec", async ({page}) => {
        await page.goto('https://playwright.dev/');
    })
    test.only("short spec 2", async ({page}) => {
        await page.goto('https://playwright.dev/');
    })
})
@yury-s
Copy link
Member

yury-s commented Dec 19, 2023

Do you have a particular use case where this is necessary?

@dimkin-eu
Copy link
Author

Having a pair of files with tests marked by '.only', I wanted to check the amount and content of tests to be run, but in place of 20-ish, I got a whole bunch of ~3000 cases. Handling fixme/skip would not be so significant.

@yury-s
Copy link
Member

yury-s commented Dec 19, 2023

We assume that .only is used just for debugging purposes and never committed to repository. Is your use case different, do you commit them to the repo?

yury-s added a commit to yury-s/playwright that referenced this issue Dec 19, 2023
yury-s added a commit that referenced this issue Dec 19, 2023
yury-s added a commit to yury-s/playwright that referenced this issue Dec 22, 2023
This reverts commit 9a5bfc5.

As it breaks extension.

Reference microsoft#28709
@yury-s yury-s reopened this Dec 22, 2023
@yury-s yury-s added the v1.42 label Dec 22, 2023
@yury-s yury-s self-assigned this Dec 22, 2023
yury-s added a commit that referenced this issue Dec 22, 2023
This reverts commit 9a5bfc5.

As it breaks extension.

Reference #28709
@yury-s yury-s removed the v1.42 label Dec 23, 2023
@yury-s yury-s removed their assignment Dec 23, 2023
@pavelfeldman
Copy link
Member

Why was this issue closed?

Thank you for your contribution to our project. This issue has been closed due to its limited upvotes and recent activity, and insufficient feedback for us to effectively act upon. Our priority is to focus on bugs that reflect higher user engagement and have actionable feedback, to ensure our bug database stays manageable.

Should you feel this closure was in error, please create a new issue and reference this one. We're open to revisiting it given increased support or additional clarity. Your understanding and cooperation are greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants