-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] clientCertificates troubleshooting #32004
Comments
@amitAutoS posting it here, so that we don't send notifications to the others. I see you are on Windows, are you using Google Chrome by any chance? Do you mind providing us your full playwright.config.ts? |
sure, here it is: import { defineConfig, devices } from "@playwright/test"; /**
/* Configure projects for major browsers / /* Run your local dev server before starting the tests */ |
I see! Google chrome has a bug (which is already fixed on beta). In order to workaround it, you need to specify a "dummy proxy" on global level. e.g.
You should be able to remove this workaround in when chrome releases version 128 on Tue, Aug 20, 2024. |
Yes Edge Stable and Chrome Stable have both the same bug. Could you try e.g. just chromium -> no channel? Firefox is hanging which is unexpected! |
Tried Chromium with no channel. Same behavior as Firefox. Tried to load the page(I dont see the cert popup) but couldn't load and dies. |
Could you try to set the |
So no additional output when you set the envs? Do you mind pinging me on Discord? Happy to investigate further there. |
I am also encountering the exact same above issue. Has a fix/ workaround been found? |
Please provide us your config file, this would help us a ton in order to triage this issue further. |
We use a bit of a custom launcher. I can also ping you on discord for more data and info. Here is the config I am using for this specific issue:
|
Feel free to ping me on Discord. |
Certain https servers like Microsoft IIS aka. TLS servers do the TLS renegotiation after the TLS handshake. This ends up in two `'secureConnect'` events due to an upstream Node.js bug: nodejs/node#54362 Drive-by: Move other listeners like `'close'` / `'end'` to `once()` as well. Relates #32004
…enegotiation Certain https servers like Microsoft IIS aka. TLS servers do the TLS renegotiation after the TLS handshake. This ends up in two `'secureConnect'` events due to an upstream Node.js bug: nodejs/node#54362 Drive-by: Move other listeners like `'close'` / `'end'` to `once()` as well. Relates #32004
I'm going to close this one for now since I believe the issues in this issue were addressed. We recommend
until we have released v1.46.1. Thank you both for your time to debug these issues together. For further reference:
For future users running into issues, please file separate bug reports - thanks! |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@playwright/test](https://playwright.dev) ([source](https://togithub.com/microsoft/playwright)) | devDependencies | patch | [`1.46.0` -> `1.46.1`](https://renovatebot.com/diffs/npm/@playwright%2ftest/1.46.0/1.46.1) | | [@playwright/test](https://playwright.dev) ([source](https://togithub.com/microsoft/playwright)) | devDependencies | minor | [`1.45.3` -> `1.46.1`](https://renovatebot.com/diffs/npm/@playwright%2ftest/1.45.3/1.46.1) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>microsoft/playwright (@​playwright/test)</summary> ### [`v1.46.1`](https://togithub.com/microsoft/playwright/releases/tag/v1.46.1) [Compare Source](https://togithub.com/microsoft/playwright/compare/v1.46.0...v1.46.1) ##### Highlights [https://github.com/microsoft/playwright/issues/32004](https://togithub.com/microsoft/playwright/issues/32004) - \[REGRESSION]: Client Certificates don't work with Microsoft IIS[https://github.com/microsoft/playwright/issues/32004](https://togithub.com/microsoft/playwright/issues/32004)4 - \[REGRESSION]: Websites stall on TLS handshake errors when using Client Certificate[https://github.com/microsoft/playwright/issues/32146](https://togithub.com/microsoft/playwright/issues/32146)46 - \[BUG]: Credential scanners warn about internal socks-proxy TLS certificat[https://github.com/microsoft/playwright/issues/32056](https://togithub.com/microsoft/playwright/issues/32056)056 - \[REGRESSION]: 1.46.0 (TypeScript) - custom fixtures extend no longer chaina[https://github.com/microsoft/playwright/issues/32070](https://togithub.com/microsoft/playwright/issues/32070)2070 - \[Bug]: --only-changed flag and project dependen[https://github.com/microsoft/playwright/issues/32188](https://togithub.com/microsoft/playwright/issues/32188)32188 - \[Bug]: --only-changed with shallow clone throws "unknown revision" error ##### Browser Versions - Chromium 128.0.6613.18 - Mozilla Firefox 128.0 - WebKit 18.0 This version was also tested against the following stable channels: - Google Chrome 127 - Microsoft Edge 127 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
Hi @mxschmitt I have tried this with the beta release and testOptions but it doesn't works as expected, I am still getting the pop-up asking to select the certificate.
here's my config:
package.json:
test file:
Originally posted by @amitAutoS in #1799 (comment)
The text was updated successfully, but these errors were encountered: