fix(esm): make sure import from './foo.js' is supported #13137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
changed the title
pavelfeldman
approved these changes
Mar 28, 2022
Drive-by: migrate all @esm tests to esm.spec.ts.
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Mar 29, 2022
…js' is supported Drive-by: migrate all @esm tests to esm.spec.ts.
|
I'm having this issue using both
Only a VSCode issue. The tests are working. If I use How can I fix? |
liuxingbaoyu
pushed a commit
to liuxingbaoyu/playwright
that referenced
this pull request
Mar 30, 2022
) Drive-by: migrate all @esm tests to esm.spec.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive-by: migrate all
@esmtests toesm.spec.ts.References #13078.