Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(screenshot): do not stall on hideHiglight attempt 2 #13222

Merged
merged 1 commit into from
Mar 31, 2022
Merged

fix(screenshot): do not stall on hideHiglight attempt 2 #13222

merged 1 commit into from
Mar 31, 2022

Commits on Mar 31, 2022

  1. fix(screenshot): do not stall on hideHiglight attempt 2 

    It turns out that "non stalling evaluate" can stall in Chromium
in some weird conditions, like `document.open` after some weird
`iframe.src` value.

We now only hide highlight in those frames where we did install
highlight in the first place.
    @dgozman
    dgozman committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    bd1bdcd View commit details
    Browse the repository at this point in the history