Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly handle character sets in globs #24371

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

aslushnikov
Copy link
Collaborator

@github-actions
Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test-ubuntu-latest-node18] › expect-to-pass.spec.ts:208:5 › should show intermediate result for toPass that spills over test time
❌ [playwright-test-macos-latest-node16] › expect-poll.spec.ts:222:5 › should show intermediate result for poll that spills over test time

7 flaky
⚠️ [chromium-ubuntu-22.04-node16] › page/page-event-request.spec.ts:129:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [firefox-ubuntu-22.04-node16] › library/tracing.spec.ts:706:5 › should not emit after w/o before
⚠️ [webkit-ubuntu-22.04-node16] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit-ubuntu-22.04-node16] › library/inspector/cli-codegen-pytest.spec.ts:56:5 › should save the codegen output to a file if specified
⚠️ [playwright-test-macos-latest-node16] › ui-mode-test-progress.spec.ts:22:5 › should update trace live
⚠️ [playwright-test-windows-latest-node16] › ui-mode-test-progress.spec.ts:218:5 › should show trace w/ multiple contexts
⚠️ [playwright-test-windows-latest-node16] › ui-mode-trace.spec.ts:126:5 › should show snapshots for sync assertions

21756 passed, 508 skipped
✔️✔️✔️

[playwright-test-ubuntu-latest-node18] › expect-to-pass.spec.ts:208:5 › should show intermediate result for toPass that spills over test time

Error: expect(received).toContain(expected) // indexOf

Expected substring: "Expected: 2"
Received string:    "
Running 1 test using 1 worker·
  ✘  1 a.spec.ts:3:11 › should fail (1.0s)··
  1) a.spec.ts:3:11 › should fail ──────────────────────────────────────────────────────────────────·
    Test timeout of 1000ms exceeded.·
  1 failed
    a.spec.ts:3:11 › should fail ───────────────────────────────────────────────────────────────────
"

  218 |   }, { timeout: 1000 });
  219 |   expect(result.exitCode).toBe(1);
> 220 |   expect(result.output).toContain('Expected: 2');
      |                         ^
  221 |   expect(result.output).toContain('Received: 3');
  222 | });
  223 |

    at /home/runner/work/playwright/playwright/tests/playwright-test/expect-to-pass.spec.ts:220:25

[playwright-test-macos-latest-node16] › expect-poll.spec.ts:222:5 › should show intermediate result for poll that spills over test time

Error: expect(received).toContain(expected) // indexOf

Expected substring: "Expected: 2"
Received string:    "
Running 1 test using 1 worker·
  ✘  1 a.spec.ts:3:11 › should fail (2.0s)··
  1) a.spec.ts:3:11 › should fail ──────────────────────────────────────────────────────────────────·
    Test timeout of 2000ms exceeded.·
  1 failed
    a.spec.ts:3:11 › should fail ───────────────────────────────────────────────────────────────────
"

  230 |   }, { timeout: 2000 });
  231 |   expect(result.exitCode).toBe(1);
> 232 |   expect(result.output).toContain('Expected: 2');
      |                         ^
  233 |   expect(result.output).toContain('Received: 3');
  234 | });
  235 |

    at /Users/runner/work/playwright/playwright/tests/playwright-test/expect-poll.spec.ts:232:25

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants