-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pass color through in web server commands #24619
Conversation
tests/library/playwright.config.ts
Outdated
reuseExistingServer: !process.env.CI, | ||
env: { | ||
PLAYWRIGHT_GRID_PORT: '3333', | ||
DEBUG: 'pw:grid*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why keep it always on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's for debugging!
this._reporter!.onStdOut?.('[WebServer] ' + line.toString()); | ||
process.stdout.write(line); | ||
if (debugWebServer.enabled || this._options.stdout === 'pipe') { | ||
this._reporter!.onStdErr?.(colors.dim('[WebServer]')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this._reporter!.onStdErr?.(colors.dim('[WebServer]')); | |
this._reporter!.onStdOut?.(colors.dim('[WebServer]')); |
c7e03f2
to
ca6ed3a
Compare
Test results for "tests 1"1 failed 4 interrupted 448 passed, 775 skipped ❌ [playwright-test-windows-latest-node16] › reporter-html.spec.ts:1452:7 › created › labels › filter should update stats
Merge workflow run. |
Test results for "tests 1"41 failed 7 flaky 25000 passed, 583 skipped ❌ [playwright-test-ubuntu-latest-node16] › web-server.spec.ts:24:5 › should create a server
❌ [playwright-test-ubuntu-latest-node16] › web-server.spec.ts:90:5 › should create a server with environment variables
❌ [playwright-test-ubuntu-latest-node16] › web-server.spec.ts:120:5 › should default cwd to config directory
❌ [playwright-test-ubuntu-latest-node16] › web-server.spec.ts:148:5 › should resolve cwd wrt config directory
❌ [playwright-test-ubuntu-latest-node16] › web-server.spec.ts:487:5 › should create multiple servers
❌ [playwright-test-ubuntu-latest-node16] › web-server.spec.ts:617:5 › should treat 3XX as available server
❌ [playwright-test-ubuntu-latest-node16] › web-server.spec.ts:663:5 › should forward stdout when set to "pipe"
❌ [playwright-test-ubuntu-latest-node16] › web-server.spec.ts:708:5 › should forward stdout when set to "pipe" before server is ready
❌ [playwright-test-ubuntu-latest-node20] › web-server.spec.ts:24:5 › should create a server
❌ [playwright-test-ubuntu-latest-node20] › web-server.spec.ts:90:5 › should create a server with environment variables
❌ [playwright-test-ubuntu-latest-node20] › web-server.spec.ts:120:5 › should default cwd to config directory
❌ [playwright-test-ubuntu-latest-node20] › web-server.spec.ts:148:5 › should resolve cwd wrt config directory
❌ [playwright-test-ubuntu-latest-node20] › web-server.spec.ts:487:5 › should create multiple servers
❌ [playwright-test-ubuntu-latest-node20] › web-server.spec.ts:617:5 › should treat 3XX as available server
❌ [playwright-test-ubuntu-latest-node20] › web-server.spec.ts:663:5 › should forward stdout when set to "pipe"
❌ [playwright-test-ubuntu-latest-node20] › web-server.spec.ts:708:5 › should forward stdout when set to "pipe" before server is ready
❌ [playwright-test-macos-latest-node16] › web-server.spec.ts:24:5 › should create a server
❌ [playwright-test-macos-latest-node16] › web-server.spec.ts:90:5 › should create a server with environment variables
❌ [playwright-test-macos-latest-node16] › web-server.spec.ts:120:5 › should default cwd to config directory
❌ [playwright-test-macos-latest-node16] › web-server.spec.ts:148:5 › should resolve cwd wrt config directory
❌ [playwright-test-macos-latest-node16] › web-server.spec.ts:487:5 › should create multiple servers
❌ [playwright-test-macos-latest-node16] › web-server.spec.ts:617:5 › should treat 3XX as available server
❌ [playwright-test-macos-latest-node16] › web-server.spec.ts:663:5 › should forward stdout when set to "pipe"
❌ [playwright-test-macos-latest-node16] › web-server.spec.ts:708:5 › should forward stdout when set to "pipe" before server is ready
❌ [playwright-test-windows-latest-node16] › ui-mode-trace.spec.ts:22:5 › should merge trace events
Retry 1:
Retry 2:
Retry 3:
❌ [playwright-test-windows-latest-node16] › ui-mode-trace.spec.ts:126:5 › should show snapshots for sync assertions
Retry 1:
Retry 2:
Retry 3:
❌ [playwright-test-windows-latest-node16] › web-server.spec.ts:24:5 › should create a server
❌ [playwright-test-windows-latest-node16] › web-server.spec.ts:90:5 › should create a server with environment variables
❌ [playwright-test-windows-latest-node16] › web-server.spec.ts:120:5 › should default cwd to config directory
❌ [playwright-test-windows-latest-node16] › web-server.spec.ts:148:5 › should resolve cwd wrt config directory
❌ [playwright-test-windows-latest-node16] › web-server.spec.ts:487:5 › should create multiple servers
❌ [playwright-test-windows-latest-node16] › web-server.spec.ts:617:5 › should treat 3XX as available server
❌ [playwright-test-windows-latest-node16] › web-server.spec.ts:663:5 › should forward stdout when set to "pipe"
❌ [playwright-test-ubuntu-latest-node18] › web-server.spec.ts:24:5 › should create a server
❌ [playwright-test-ubuntu-latest-node18] › web-server.spec.ts:90:5 › should create a server with environment variables
❌ [playwright-test-ubuntu-latest-node18] › web-server.spec.ts:120:5 › should default cwd to config directory
❌ [playwright-test-ubuntu-latest-node18] › web-server.spec.ts:148:5 › should resolve cwd wrt config directory
❌ [playwright-test-ubuntu-latest-node18] › web-server.spec.ts:487:5 › should create multiple servers
❌ [playwright-test-ubuntu-latest-node18] › web-server.spec.ts:617:5 › should treat 3XX as available server
❌ [playwright-test-ubuntu-latest-node18] › web-server.spec.ts:663:5 › should forward stdout when set to "pipe"
❌ [playwright-test-ubuntu-latest-node18] › web-server.spec.ts:708:5 › should forward stdout when set to "pipe" before server is ready
Merge workflow run. |
ca6ed3a
to
f99713a
Compare
f99713a
to
2bc658a
Compare
Test results for "tests 1"1 failed 10 flaky 25037 passed, 583 skipped ❌ [playwright-test-windows-latest-node16] › expect-poll.spec.ts:158:5 › should support .not predicate
Merge workflow run. |
No description provided.