Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unhide merge-reports command #32605

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Sep 13, 2024

Context #30962 (comment)
Reverts #22509

cc @muhqu

Signed-off-by: Max Schmitt <max@schmitt.mx>
@muhqu
Copy link
Contributor

muhqu commented Sep 13, 2024

@mxschmitt I still wonder why it was explicitly marked hidden in the first place.

@mxschmitt
Copy link
Member Author

We released the feature in v1.37, which was released in Aug 11, 2023. We were hiding it in Apr 20, 2023, so probably it wasn't ready back then. We usually hide things if we don't consider them ready.

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › babel.spec.ts:135:5 › should not transform external

1 flaky ⚠️ [webkit-library] › library/download.spec.ts:698:3 › should convert navigation to a resource with unsupported mime type into download

35418 passed, 659 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 9e99c86 into main Sep 13, 2024
29 of 30 checks passed
@mxschmitt mxschmitt deleted the mxschmitt/unhide-merge-reports-command branch September 13, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants