docs(click): mention that trial emits keydown/keyup if modifier is given #32730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Sep 20, 2024
| * since: v1.11 | ||
| - `trial` <[boolean]> | ||
|
|
||
| When set, this method only performs the [actionability](../actionability.md) checks, emits a `keydown`/`keyup` event if a `modifier` is passed and skips the action. Defaults to `false`. Useful to wait until the element is ready for the action without performing it. |
There was a problem hiding this comment.
What about mouse move, do we want to mention it for completeness? If not I'd reword it to say explicitly what it does not do (mouse down/up) and then say something like 'Note that if a modifier is passed, the call will fire keydown/keyup events .'
Test results for "tests 1"2 failed 1 flaky35678 passed, 668 skipped Merge workflow run. |
|
@mxschmitt @yury-s here is an alternative documentation fix: #32734 It addresses all cases where |
|
Superseded by #32734 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32703