Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve docs for WebSocketRoute #33097

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Oct 14, 2024

Closes #33093.

Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments + maybe we should throw if a user passes a URL to routeWebSocket which starts with http or https.

docs/src/api/class-websocketroute.md Outdated Show resolved Hide resolved
docs/src/mock.md Outdated Show resolved Hide resolved
docs/src/network.md Outdated Show resolved Hide resolved

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

2 fatal errors, not part of any test

3 flaky ⚠️ [webkit-library] › library/screenshot.spec.ts:204:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:22:5 › should run global setup and teardown @windows-latest-node18-1
⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config @windows-latest-node18-1

35944 passed, 620 skipped, 1 did not run
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit 8a275e5 into microsoft:main Oct 15, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[internal]: WebsocketRoute feedback
2 participants