Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pull request link pr_check_client_side_changes.yml #33189

Merged
merged 4 commits into from
Oct 20, 2024

Conversation

Meir017
Copy link
Contributor

@Meir017 Meir017 commented Oct 20, 2024

current issue description:

example of current:

Please backport client side changes:
  - [ ] https://github.com/microsoft/playwright/commit/6373fe703dbde7fc40e11a006e48476579664c1a (docs: fix Java/.NET types for docs rolling (#32924))
  - [ ] https://github.com/microsoft/playwright/commit/94321fef1c94f9851b6fcc4304d3844760e986cb (chore: implement locator.ariaSnapshot (#33125))

new rendered description:

Please backport client side changes:
  - [ ] https://github.com/microsoft/playwright/commit/6373fe703dbde7fc40e11a006e48476579664c1a (docs: fix Java/.NET types for docs rolling (https://github.com/microsoft/playwright/pull/32924))
  - [ ] https://github.com/microsoft/playwright/commit/94321fef1c94f9851b6fcc4304d3844760e986cb (chore: implement locator.ariaSnapshot (https://github.com/microsoft/playwright/pull/33125))

rendered as:
image

by modifying the pull request id to be an absolute URL to this repository the pull request link will appear in the brackets as well.

something like this:

Please backport client side changes:

(works here due to these pull request ids being from this repo)

This comment has been minimized.

Meir017 and others added 2 commits October 20, 2024 19:27
Co-authored-by: Max Schmitt <max@schmitt.mx>
Signed-off-by: Meir Blachman <meirblachman@gmail.com>
@mxschmitt mxschmitt merged commit 4b18710 into microsoft:main Oct 20, 2024
28 of 29 checks passed
@Meir017 Meir017 deleted the patch-3 branch October 20, 2024 16:49
Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:116:5 › mobile viewport › default mobile viewports to 980 width @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:75:14 › page screenshot › should work with device scale factor @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/screenshot.spec.ts:204:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

36431 passed, 639 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants