fix(codegen): document.documentElement is null on early navigation #33627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following when opening Codegen on https://primevue.org/inputnumber/:
In TypeScript this type is not nullable. This is working as intended from their side: microsoft/TypeScript#50078
Minimal Playwright repro script. This sometimes returns
true
and sometimesfalse
.Contract-wise we have three users of
Highlight::install
:The first one retries every couple of seconds. The other two we expect to be called after the navigation has happened IIUC.
I went over the rest of the code-base, there we usually check for null when interacting with
document.documentElement
.