Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): show details about missing dependencies #3839

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

PMudra
Copy link
Contributor

@PMudra PMudra commented Sep 10, 2020

Convert file names of missing windows dependencies to lower case.
This enables the detailed error message about missing media feature pack.
Also provide a link to the official support page on how to optain the media features for Windows N releases.

When I tried to launch webkit I got this error message:

    browserType.launch: Host system is missing dependencies!

    Full list of missing libraries:
        EVR.dll

    Note: use DEBUG=pw:api environment variable and rerun to capture Playwright logs.

With with fix I am now getting the much more useful message:

    browserType.launchPersistentContext: Host system is missing dependencies!

    Some of the Media Foundation files cannot be found on the system. If you are
    on Windows Server try fixing this by running the following command in PowerShell
    as Administrator:

        Install-WindowsFeature Server-Media-Foundation

    For Windows N editions visit:
    https://support.microsoft.com/en-us/help/3145500/media-feature-pack-list-for-windows-n-editions

    Full list of missing libraries:
        evr.dll

    Note: use DEBUG=pw:api environment variable and rerun to capture Playwright logs.

Convert file names of missing windows dependencies to lower case.
This enables the detailed error message about missing media feature pack.
Also provide a link to the official support page on how to optain the media features for Windows N releases.
@yury-s yury-s merged commit 1e600cb into microsoft:master Sep 10, 2020
@PMudra PMudra deleted the windows-dep-check branch September 11, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants