feat(browserContext): add BrowserContext.browser() #3849
Conversation
src/client/browserContext.ts
Outdated
| @@ -92,6 +92,10 @@ export class BrowserContext extends ChannelOwner<channels.BrowserContextChannel, | |||
| this._channel.setDefaultTimeoutNoReply({ timeout }); | |||
| } | |||
|
|
|||
| browser(): Browser { | |||
| return this._browser!; | |||
There was a problem hiding this comment.
not sure about the !. There should be always a browser instance.
There was a problem hiding this comment.
We should probably change the type of this field to Browser and throw in the constructor if parent instanceof Browser check fails.
mxschmitt
force-pushed
the
feature/browser-context-browser
branch
from
26543ee
to
a1175f6
Compare
src/client/browserContext.ts
Outdated
| @@ -92,6 +92,10 @@ export class BrowserContext extends ChannelOwner<channels.BrowserContextChannel, | |||
| this._channel.setDefaultTimeoutNoReply({ timeout }); | |||
| } | |||
|
|
|||
| browser(): Browser { | |||
| return this._browser!; | |||
There was a problem hiding this comment.
We should probably change the type of this field to Browser and throw in the constructor if parent instanceof Browser check fails.
mxschmitt
force-pushed
the
feature/browser-context-browser
branch
2 times, most recently
from
dbd503a
to
4cb4aab
Compare
mxschmitt
force-pushed
the
feature/browser-context-browser
branch
from
4cb4aab
to
efdebf9
Compare
When a browser was launched with a persistent context, then browser was undefined. Changed it to null, so it reflects to our current API design. (We don't expose undefined only null for nil elements). |
Talked with Pavel about that.