Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor goBack/goForward/reload #3859

Merged
merged 1 commit into from
Sep 14, 2020
Merged

chore: refactor goBack/goForward/reload #3859

merged 1 commit into from
Sep 14, 2020

Commits on Sep 14, 2020

  1. chore: refactor goBack/goForward/reload 

    These methods are the only users of waitForNavigation and
waitForLoadState on the server side. This refactor lifts the
Progress wrapper to the top-most goBack/goForward/reload call
and leaves waitForNavigation/waitForLoadState as internal helpers.
This way we get a single Progress for the actual api call.
    @dgozman
    dgozman committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    e9dae02 View commit details
    Browse the repository at this point in the history