chore: add devcontainer.json for GitHub Codespaces #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunattam
approved these changes
Sep 12, 2020
| "image": "mcr.microsoft.com/playwright:next", | ||
| "postCreateCommand": "npm install && npm run build", | ||
| "settings": { | ||
| "terminal.integrated.shell.linux": "/bin/bash" |
There was a problem hiding this comment.
Curious to know why this is required?
There was a problem hiding this comment.
By default it uses /bin/sh which is not very user friendly. On the SuperLinter project of GitHub they are doing that too: https://github.com/github/super-linter/blob/master/.devcontainer/devcontainer.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since more and more people are getting access to GitHub Codespaces and we want to make it for new contributors as easy as possible to contribute to the project I've added a GitHub Codespaces configuration.
This makes it possible for users per one click to get a new instance of the repo, which is based on our "tip of tree" Docker image, installs all our NPM packages, built it and make it ready for running e.g.
yarn ctest.