devops(docker): added Dockerfile for Ubuntu 20 focal #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Sep 17, 2020
docs/docker/build.sh
Outdated
| echo "Once image is built, you can run it with" | ||
| echo "" | ||
| echo " docker run --rm -it playwright:localbuild /bin/bash" | ||
| echo " docker run --rm -it playwright:localbuild-{bionic,focal} /bin/bash" |
There was a problem hiding this comment.
docs/docker/tag_and_push.sh should be updated too according to these changes.
Let's accept image name as an argument both here and in docs/docker/tag_and_push.sh?
mxschmitt
force-pushed
the
devops/docker-focal
branch
from
7248409
to
6ca9e7b
Compare
aslushnikov
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each Ubuntu and Debian release has a code name. Ubuntu 18(bionic), Ubuntu 20(focal). This adds the Dockerfile for Ubuntu20.
Next steps and follow up changes:
This naming schema allows us in the future to add Debian support too. But we should wait until Headless WK is fixed.
Relates #3791
Relates #2758
Closes #3338