fix: wait for ffmpeg to finish writing even if page was closed #6648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
May 19, 2021
aslushnikov
pushed a commit
to aslushnikov/playwright
that referenced
this pull request
May 19, 2021
Cherry-picking PR microsoft#6648 SHA b946437
yury-s
added a commit
to yury-s/playwright
that referenced
this pull request
May 19, 2021
aslushnikov
added a commit
that referenced
this pull request
May 19, 2021
aslushnikov
pushed a commit
to aslushnikov/playwright
that referenced
this pull request
May 20, 2021
- Cherry-Pick PR microsoft#6648 SHA b946437 - Cherry-Pick PR microsoft#6664 SHA 2ef47b9 References microsoft/playwright-java#432
aslushnikov
added a commit
that referenced
this pull request
May 20, 2021
- Cherry-Pick PR #6648 SHA b946437 - Cherry-Pick PR #6664 SHA 2ef47b9 References microsoft/playwright-java#432 Co-authored-by: Yury Semikhatsky <yurys@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was introduced in 53d50f9. The problem was that the video was removed from the map when the page was closing, after that
context.close()wouldn't find the video artifact and wouldn't wait for it. Since page.close itself doesn't wait for the video to complete we could end up closing context and browser before the video was fully written to disk.Refs: microsoft/playwright-java#432