fix microsoft/powercat-creator-kit#352

microsoft · Jul 10, 2023 · cf93a6b · cf93a6b
1 parent b54ebe8
commit cf93a6b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/SearchBox/SearchBox/components/SearchBox.tsx b/SearchBox/SearchBox/components/SearchBox.tsx
@@ -34,8 +34,9 @@ export const SearchBoxComponent = React.memo((props: ISearchBoxComponentProps) =
     }, [value]);
 
     function onChangeEvent(ev?: React.ChangeEvent<HTMLInputElement>, newValue?: string) {
-        setSearchText(newValue);
-        onChange(ev, newValue);
+        // pass empty string in case the value is undefined or null
+        setSearchText(newValue ?? '');
+        onChange(ev, newValue ?? '');
     }
 
     const searchboxStyles = React.useMemo(() => {

diff --git a/SearchBox/SearchBox/index.ts b/SearchBox/SearchBox/index.ts
@@ -84,10 +84,10 @@ export class SearchBox implements ComponentFramework.ReactControl<IInputs, IOutp
      * Called when a change is detected from the control. Updates the searchTextValue variable that is assigned to the output SearchText.
      * @param newValue a string returned as the input search text
      */
-    private onChanged = (event?: React.ChangeEvent<HTMLInputElement>, newValue?: string): void => {
+    private onChanged = (event: React.ChangeEvent<HTMLInputElement>, newValue: string): void => {
         // If the new Value is different from searchTextValue
         if (this.searchTextValue !== newValue) {
-            this.searchTextValue = newValue ?? '';
+            this.searchTextValue = newValue;
             this.delayOutput
                 ? this.debouncedOutputChanged && this.debouncedOutputChanged()
                 : this.notifyOutputChanged && this.notifyOutputChanged();