Improved consistency of unreachable code. Previously, unreachable cod… #8190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e was not supported for `if` or `else` suites when the condition type was narrowed to `Never`. This addresses microsoft/pylance-release#6028.
|
Diff from mypy_primer, showing the effect of this PR on open source code: dd-trace-py (https://github.com/DataDog/dd-trace-py)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/appsec/_iast/taint_sinks/_base.py:132:28 - error: Expected no arguments to "Evidence" constructor (reportCallIssue)
- /tmp/mypy_primer/projects/dd-trace-py/tests/utils.py:1303:17 - error: Expression of type "datetime" is incompatible with declared type "int"
- "datetime" is incompatible with "int" (reportAssignmentType)
- 11603 errors, 583 warnings, 0 informations
+ 11601 errors, 583 warnings, 0 informations
pandera (https://github.com/pandera-dev/pandera)
- /tmp/mypy_primer/projects/pandera/tests/core/test_schema_components.py:475:52 - error: Cannot access attribute "tolist" for class "Iterable[Unknown]"
- Attribute "tolist" is unknown (reportAttributeAccessIssue)
- 2032 errors, 25 warnings, 0 informations
+ 2031 errors, 25 warnings, 0 informations
trio (https://github.com/python-trio/trio)
- /tmp/mypy_primer/projects/trio/src/trio/_core/_tests/test_run.py:2271:12 - error: Type of "coro" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/trio/src/trio/_core/_tests/test_run.py:2271:12 - error: Type of "throw" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/trio/src/trio/_core/_tests/test_run.py:2272:28 - error: Type of "Error" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/trio/src/trio/_core/_tests/test_run.py:2273:10 - error: Type of "raises" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/trio/src/trio/_subprocess_platform/waitid.py:108:9 - error: Argument type is partially unknown
- Argument corresponds to parameter "args" in function "spawn_system_task"
- Argument type is "*tuple[Unknown, Event]" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/trio/src/trio/_tests/test_channel.py:384:10 - error: Type of "raises" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/trio/src/trio/_tests/test_channel.py:390:14 - error: Type of "raises" is unknown (reportUnknownMemberType)
- 3760 errors, 52 warnings, 0 informations
+ 3753 errors, 52 warnings, 0 informations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e was not supported for
iforelsesuites when the condition type was narrowed toNever. This addresses microsoft/pylance-release#6028.