Turn off path watcher by default #1841
Conversation
This reverts commit 6109ac7.
|
Can you add something to TROUBLESHOOTING with regards to this? Something like: |
|
Hi, is the hypothesis here that the filesystem watcher itself is broken or there is some issue in the interaction between watcher and language server? Is there some other issue/repo where we could track this? |
|
Mainly the latter, but there are other issues with file watching. Having the watcher on all the time breaks the analysis if it's in progress (usually not, but sometimes yes), which isn't a simple fix. Past that, the watcher appears to fire without reason on some systems, and not operate at all on others. There is not an open issue about reenabling this at the moment, no. A better solution is to make the LSP client do this, but that has its issues as well. |
|
Just an idea, would it help to ignore (queue) the events while analysis is in progress? If you think this would help, we can try to make a PR. |
|
There are more issues than just reset during analysis. Sometimes it is hard to tell library code from user code so we had issues when user changing their code triggers complete reload. "python.analysis.watchSearchPaths": true |
* Remove stale reference * Don't suppress LHS diagnostics on augmented assign * Revert "Don't suppress LHS diagnostics on augmented assign" This reverts commit 6109ac7. * Escape [ and ] * PR feedback * Turn off file watcher by default * Update per change to the setting default (cherry picked from commit 226221e)
* Remove stale reference * Don't suppress LHS diagnostics on augmented assign * Revert "Don't suppress LHS diagnostics on augmented assign" This reverts commit 6109ac7. * Escape [ and ] * PR feedback * Turn off file watcher by default * Update per change to the setting default (cherry picked from commit 226221e)
|
For some reason I'm not seeing the python.analysis.watchSearchPaths setting? Using vscode v1.49 on osx. Any advice? |
|
It's a hidden setting. You can ignore the warning from the editor. You may want to consider using Pylance, which doesn't suffer from the problems leading to the disabling of file watching. |
|
Lol, I literally just had the realization that it was a hidden setting after spending hours on this... Thanks @jakebailey ! Pylance looks super interesting, and worked perfectly; will run with that. Thanks for the help! |
Fixes #1608
Fixes #1800
Fixes #1834
Fixes #1839