Apply flake8-pyi autofixes #340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Nov 8, 2024
pyproject.toml
Outdated
Comment on lines
41
to
58
| "PYI019", # Request for autofix: https://github.com/astral-sh/ruff/issues/14183 | ||
| "PYI021", # Request for autofix: https://github.com/astral-sh/ruff/issues/14123 | ||
| "PYI024", | ||
| "PYI034", # Request for autofix: https://github.com/astral-sh/ruff/issues/14184 | ||
| "PYI041", # Request for autofix: https://github.com/astral-sh/ruff/issues/14185 | ||
| "PYI044", # Request for autofix: https://github.com/astral-sh/ruff/issues/14186 | ||
| "PYI048", | ||
| "PYI051", # Request for autofix: https://github.com/astral-sh/ruff/issues/14185 | ||
| "PYI052", | ||
| "PYI062", # Request for autofix: https://github.com/astral-sh/ruff/issues/14187 |
There was a problem hiding this comment.
References:
Request: Fix to remove docstrings in stubs (PYI021/docstring-in-stub) astral-sh/ruff#14123- Request: Unsafe fix for
custom-type-var-return-type/PYI019astral-sh/ruff#14183 - Request: Unsafe fix for
non-self-return-type/PYI034astral-sh/ruff#14184 - Request: Autofix for
redundant-numeric-union/PYI041&redundant-literal-union/PYI051astral-sh/ruff#14185 Request: Autofix forfuture-annotations-in-stub/PYI044astral-sh/ruff#14186Request: More autofixes forduplicate-literal-member/PYI062astral-sh/ruff#14187
PYI021 is also done separately in #343
Avasam
force-pushed
the
apply-flake8-pyi-autofixes
branch
2 times, most recently
from
c5b0e57
to
75fc33c
Compare
Avasam
force-pushed
the
apply-flake8-pyi-autofixes
branch
from
75fc33c
to
4f2c818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(based on #339, so merge that one first)DoneI added
PYIto Ruff'sselect. https://docs.astral.sh/ruff/rules/#flake8-pyi-pyiThen run
ruff check --fix --preview:Found 1776 errors (967 fixed, 809 remaining).Then ignore the checks still failing to keep this PR to automated fixes only. (because Ruff has no config to set as warning: astral-sh/ruff#1256)
Note that
flake8-future-annotations (FA)was already passing on main, so I just included it.