This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 93
Made Width and Depth compatible in current version of the tracer #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryVasilevsky
requested review from
IrinaYatsenko,
avasch01,
vadym-kl and
bettinaheim
October 20, 2020 02:11
bettinaheim
reviewed
Oct 20, 2020
The failing iqsharp build seems to be due to a test that simply needs to be updated. |
cgranade
reviewed
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this! I think the main thing that jumps out at me as a user of the trace simulator is that, as per @bettinaheim's comments, it's not really clear what ExtraWidth is and what that metric tracks about the execution of a quantum program.
src/Simulation/QCTraceSimulator/QubitAvailabilityTimeTracker.cs
Outdated
Show resolved
Hide resolved
src/Simulation/QCTraceSimulator/QubitAvailabilityTimeTracker.cs
Outdated
Show resolved
Hide resolved
src/Simulation/QCTraceSimulator/QubitAvailabilityTimeTracker.cs
Outdated
Show resolved
Hide resolved
bettinaheim
reviewed
Oct 21, 2020
bettinaheim
approved these changes
Oct 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
avasch01
reviewed
Oct 22, 2020
avasch01
reviewed
Oct 22, 2020
avasch01
reviewed
Oct 22, 2020
avasch01
approved these changes
Oct 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracer component now produces compatible "Width" and "Depth" metrics, both computed in the depth counter. "Width" previously computed by the width counter is still reported as "QubitCount". User can request width or depth optimized circuit to get compatible width and height in desired case. For example,
will result in Width=1, Depth=2 when OptimizeDepth is false, and Width=2, Depth=1 when OptimizeDepth is true. For compatibility "QubitCount" is kept and will still be reported as 1.