Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single line TextInput onSubmitEditing doesn't work #451

Closed
byw opened this issue Jun 13, 2020 · 2 comments · Fixed by #458
Closed

Single line TextInput onSubmitEditing doesn't work #451

byw opened this issue Jun 13, 2020 · 2 comments · Fixed by #458
Assignees
@tido64

Comments

@byw
Copy link

byw commented Jun 13, 2020 •
edited
Loading

Environment

  1. react-native -v: 0.62.13
  2. npm ls react-native-macos: 0.61.0-0
  3. node -v: 12.18.0
  4. npm -v: 6.14.4
  5. yarn --version: 1.22.4
  6. xcodebuild -version: 11E608c

Issue

TextInput in single-line mode doesn't trigger onSubmitEditing event when I press enter.

Steps to Reproduce

  1. Hookup onSubmitEnter to a callback.
  2. console.log a debug line in callback.
  3. Type something, press enter

Expected Behavior

The callback should be called, producing console output.

Actual Behavior

The callback is not called - no message printed to console.
It does work, however, in multiline when I hit Cmd-Enter.
@ghost ghost added the Needs: Triage 🔍 label Jun 13, 2020
@tom-un
Copy link
Collaborator

tom-un commented Jun 17, 2020

Thanks. I think this was resolved in a PR for another issue. @tido64 : can you confirm?

@tido64
Copy link
Member

tido64 commented Jun 17, 2020

Only onSubmitEditing in multi-line TextInput was fixed (#442). I can take a look at this one next.

@tido64 tido64 mentioned this issue Jun 18, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tido64 tido64

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix onSubmitEditing not being called on single-line TextInput tido64/react-native
3 participants
@byw @tido64 @tom-un