Fix onSubmitEditing firing on delete/tab #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-[RCTBaseTextInputView textInputShouldReturn]` also sends a submit event.
tido64
commented
Jun 10, 2020
| @@ -353,7 +353,7 @@ - (BOOL)textView:(NSTextView *)textView doCommandBySelector:(SEL)commandSelector | |||
| BOOL commandHandled = NO; | |||
| id<RCTBackedTextInputDelegate> textInputDelegate = [_backedTextInputView textInputDelegate]; | |||
| // enter/return | |||
| if (textInputDelegate.textInputShouldReturn && (commandSelector == @selector(insertNewline:) || commandSelector == @selector(insertNewlineIgnoringFieldEditor:))) { | |||
| if ((commandSelector == @selector(insertNewline:) || commandSelector == @selector(insertNewlineIgnoringFieldEditor:)) && textInputDelegate.textInputShouldReturn) { | |||
There was a problem hiding this comment.
@tom-un, @shergin, @TheSavior: I don't have the full context on why textInputShouldReturn also sends a submit event. Is this something we should fix upstream to avoid future surprises?
There was a problem hiding this comment.
Also, the current behaviour is to always submit when pressing Enter. Is that the correct behaviour? How would one normally input a newline in a multiline TextInput? I had assumed that one would press Enter for newline, and submit with Cmd+Enter.
There was a problem hiding this comment.
Changed it to submit only on ⌘+Enter.
tom-un
reviewed
Jun 11, 2020
tom-un
approved these changes
Jun 16, 2020
This was referenced Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
onSubmitEditingis fired on delete/tab keys because we check-[RCTBaseTextInputView textInputShouldReturn], which also sends a submit event, too early.Resolves #429
Changelog
[macOS] [Fixed] - Fix onSubmitEditing firing on delete/tab
Test Plan
Microsoft Reviewers: Open in CodeFlow