forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update paths to binaries #1294
Merged
Merged
update paths to binaries #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogError: RequestError [HttpError]: Must have admin rights to Repository.
at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
status: 403,
response: {
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1294/labels',
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Wed, 27 Jul 2022 19:15:20 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'GitHub.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-oauth-scopes': '',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'EA8C:77BA:82B69C:F6F928:62E18EC8',
'x-oauth-scopes': 'public_repo',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4978',
'x-ratelimit-reset': '1658951837',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '22',
'x-xss-protection': '0'
},
data: {
message: 'Must have admin rights to Repository.',
documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/microsoft/react-native-macos/issues/1294/labels',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit-rest.js/18.12.0 octokit-core.js/3.5.1 Node.js/14.18.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"labels":["Pick Request"]}',
request: { hook: [Function: bound bound register] }
}
}
danger-results://tmp/danger-results.json |
mganandraj
approved these changes
Jul 28, 2022
rasaha91
added a commit
to rasaha91/react-native-macos
that referenced
this pull request
Jul 28, 2022
update paths to binaries
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1294 Pull Request resolved: facebook#37383 Add -Wextra to the build, and fixup some more instances of -Wunused-parameter that it sufaces which were not automatically fixable. Reviewed By: javache Differential Revision: D45772846 fbshipit-source-id: 59e7993efe0731b4dc2d5683d1670e934617c17d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Facebook changed the ndk build step to use a gradle plugin, which lead to the libraries being produced to different paths. As a result, we fail to find the libraries when performing a nuget pack.
Changelog
[Android] [Internal] - Update binary paths
Test Plan
Will verify the nuget pack task doesn't fail to find any of the expected files.