Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.73-stable] Add mouse hover events to RCTTextView #2143

Merged
merged 14 commits into from
Jul 10, 2024
Merged

[0.73-stable] Add mouse hover events to RCTTextView #2143

merged 14 commits into from
Jul 10, 2024

Commits on Jun 25, 2024

  1. Initial implementation

    Adam Gleitman committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    387e28f View commit details
    Browse the repository at this point in the history

  2. Refactor and dedupe some code

    Adam Gleitman committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3e5ec21 View commit details
    Browse the repository at this point in the history

  3. Basic error handling

    Adam Gleitman committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8b9a344 View commit details
    Browse the repository at this point in the history

  4. Clarify comment about mousemove order

    Adam Gleitman committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    bcbf64c View commit details
    Browse the repository at this point in the history

  5. Cleanup: enumerate all text attributes at once instead of doing multi… 

    …ple passes
    Adam Gleitman committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    f8f9ab0 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Use *shadow* view traversal for handling nested mouse events

    Adam Gleitman committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5a7a39e View commit details
    Browse the repository at this point in the history

  2. Remove potentially confusing comment

    Adam Gleitman committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3866165 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. descendantViewTags doesn't need to worry about duplicates

    Adam Gleitman committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    942c7d6 View commit details
    Browse the repository at this point in the history

  2. Distinguish between embedded views and virtual text subviews

    Adam Gleitman committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    ee372a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Scope _virtualSubviews to macOS only

    Adam Gleitman committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    194ee9d View commit details
    Browse the repository at this point in the history

  2. nit: use separate #if blocks for setTextStorage:... and `getRectFor… 

    …CharRange:` inclusions
    Adam Gleitman committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d4e402f View commit details
    Browse the repository at this point in the history

  3. TARGET_OS_OSX blocks for virtualSubviewTags

    Adam Gleitman committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    7fbf20c View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Remove #if TARGET_OS_OSX blocks, since these changes are potentially … 

    …upstreamable
    Adam Gleitman committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    bc4d5d0 View commit details
    Browse the repository at this point in the history

  2. Clarify a TODO

    Adam Gleitman committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    bcaee62 View commit details
    Browse the repository at this point in the history