Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Post NSAccessibilityLayoutChangedNotification when we call setAccessibilityFocus on macOS #872

Conversation

amgleitman
Copy link
Member

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

On iOS, we post a notification when we call AccessibilityInfo.setAccessibilityFocus as per this line, but we don't yet do the same on macOS. This fixes that issue.

Changelog

[macOS] [Fixed] - Post NSAccessibilityLayoutChangedNotification when we call setAccessibilityFocus

Test Plan

Validated by running through RNTester and seeing that the notification gets posted.

@amgleitman amgleitman requested a review from alloy as a code owner October 27, 2021 22:24
@amgleitman amgleitman merged commit 4baf0f3 into microsoft:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants