forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] small tweaks & bump VMs in CI #979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Jan 24, 2022
kelset
force-pushed
the
kelset/update-vms-for-ado
branch
from
January 26, 2022 15:42
cf5e998
to
be98d6d
Compare
Update on this PR - I spent some time trying to get to the bottom of the CI ❌
This is because I noticed that CI seems faulty in main: |
kelset
force-pushed
the
kelset/update-vms-for-ado
branch
from
February 2, 2022 13:09
8792d78
to
599e017
Compare
kelset
force-pushed
the
kelset/update-vms-for-ado
branch
from
February 3, 2022 10:33
599e017
to
599f70a
Compare
kelset
force-pushed
the
kelset/update-vms-for-ado
branch
from
February 4, 2022 10:51
599f70a
to
2bf6460
Compare
kelset
requested review from
HeyImChris and
Saadnajmi
and removed request for
alloy
February 4, 2022 16:25
HeyImChris
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
(wasn't really sure what to pick tbh)
Summary
While digging around the code I noticed that the ADO vms used by this repo are a bit outdated. So I tweaked a bit the vars.yml file, added all the referenced VMs, and updated to newer versions.
I've matched the "latest" ones but used the fixed reference, according to the docs: https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml#software
This is aligned with what react-native-test-app is using: https://github.com/microsoft/react-native-test-app/blob/trunk/.github/workflows/build.yml
Moreover, I've set the Xcode version to match the one set as default by the new macos VM: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md#xcode
This is actually something we might want to discuss about, since technically in the CircleCI config we should also change to match, potentially: https://github.com/microsoft/react-native-macos/blob/main/.circleci/config.yml#L55
I didn't change it since it seems to be a config we have in place just because we're a fork of core and they have a CircleCI config? https://github.com/facebook/react-native/blob/1b31d6bb582768ccbe92d3c1a9e43354a8c531e5/.circleci/config.yml#L55
So wanted to check before diverging from upstream.
To sum it up:
ubuntu-18.04
->ubuntu-20.04
macOS-10.15
->macOS-11
Xcode_12_4
->Xcode_13_1
Test Plan
Running on CI is itself the test, let's see how it goes :)