Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] small tweaks & bump VMs in CI #979

Merged
merged 10 commits into from
Feb 4, 2022
Merged

Conversation

kelset
Copy link

@kelset kelset commented Jan 24, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

(wasn't really sure what to pick tbh)

Summary

While digging around the code I noticed that the ADO vms used by this repo are a bit outdated. So I tweaked a bit the vars.yml file, added all the referenced VMs, and updated to newer versions.
I've matched the "latest" ones but used the fixed reference, according to the docs: https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml#software
This is aligned with what react-native-test-app is using: https://github.com/microsoft/react-native-test-app/blob/trunk/.github/workflows/build.yml

Moreover, I've set the Xcode version to match the one set as default by the new macos VM: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md#xcode

This is actually something we might want to discuss about, since technically in the CircleCI config we should also change to match, potentially: https://github.com/microsoft/react-native-macos/blob/main/.circleci/config.yml#L55

I didn't change it since it seems to be a config we have in place just because we're a fork of core and they have a CircleCI config? https://github.com/facebook/react-native/blob/1b31d6bb582768ccbe92d3c1a9e43354a8c531e5/.circleci/config.yml#L55

So wanted to check before diverging from upstream.

To sum it up:

  • ubuntu-18.04 -> ubuntu-20.04
  • macOS-10.15 -> macOS-11
  • Xcode_12_4 -> Xcode_13_1

Test Plan

Running on CI is itself the test, let's see how it goes :)

@kelset kelset requested a review from alloy as a code owner January 24, 2022 18:29
@kelset kelset added the JSHost label Jan 24, 2022
.ado/publish.yml Outdated Show resolved Hide resolved
.ado/variables/vars.yml Show resolved Hide resolved
@kelset kelset force-pushed the kelset/update-vms-for-ado branch from cf5e998 to be98d6d Compare January 26, 2022 15:42
@Saadnajmi Saadnajmi mentioned this pull request Jan 27, 2022
4 tasks
@kelset
Copy link
Author

kelset commented Jan 27, 2022

Update on this PR - I spent some time trying to get to the bottom of the CI ❌

Screenshot 2022-01-27 at 15 00 36

I did some basic digging around but I couldn't find anything specific that could address it, so I'll go into the 0.66 branch, verify if it happens there, and adapt accordingly. Will report back afterwards.

This is because I noticed that CI seems faulty in main:

@kelset kelset force-pushed the kelset/update-vms-for-ado branch from 8792d78 to 599e017 Compare February 2, 2022 13:09
@kelset kelset requested a review from a team as a code owner February 2, 2022 13:09
@kelset kelset force-pushed the kelset/update-vms-for-ado branch from 599e017 to 599f70a Compare February 3, 2022 10:33
@kelset kelset force-pushed the kelset/update-vms-for-ado branch from 599f70a to 2bf6460 Compare February 4, 2022 10:51
@kelset kelset requested review from HeyImChris and Saadnajmi and removed request for alloy February 4, 2022 16:25
@HeyImChris HeyImChris merged commit 6a6e7fa into main Feb 4, 2022
@kelset kelset deleted the kelset/update-vms-for-ado branch February 4, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants