Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Regression Test for RNW:9662 #10523

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

aeulitz
Copy link
Contributor

@aeulitz aeulitz commented Sep 8, 2022

Add Regression Test for RNW:9662

Type of Change

  • add automated test

Why

  • Prevent regression of debugging features

What

The fix has been pushed to FB RN per facebook/react-native#34342. Until hermes-windows picks up the containing FB ReactCommon version, the fix has been duplicated into hermes-windows as patch per microsoft/hermes-windows#122.

This change adds an automated test for the fix to RNW.

Microsoft Reviewers: Open in CodeFlow

@aeulitz aeulitz requested a review from a team as a code owner September 8, 2022 00:57
Copy link
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeulitz aeulitz merged commit f96ab5e into microsoft:main Sep 8, 2022
@aeulitz aeulitz deleted the DebugHangTest branch September 12, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants