Fix loading images from file:// URIs
#12757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the loading of images via
file://URIs, which is what is used for asset files in (unpackaged) Fabric apps.Type of Change
Why
To fix image loading.
Resolves #12755
What
The API we use to load the image can support
file://URI's directly, we were doing a bunch of (now no longer necessary?) path processing that ultimately wasn't working. This change removes that processing.Screenshots
Before:
After:
Testing
Verified images started loading.
Changelog
Should this change be included in the release notes: yes
Fixed loading images from
file://URIs (as used for assets in on-disk bundles)Microsoft Reviewers: Open in CodeFlow