Remove OpenSSL from Desktop LIB and DLL #13321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it still needed in the various other projects (test projects) that still have the dependency? |
Yes. But I will evaluate migrating all involved tests to rely on the Test Website instead. This change is to remove the unused dependency in production code. |
acoates-ms
approved these changes
Jun 10, 2024
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jul 19, 2024
* Remove OpenSSL from Desktop LIB and DLL * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove OpenSSL NuGet dependency from Desktop LIB and DLL projects.
Type of Change
Why
Package
ReactWindows.OpenSSL.StdCall.Staticis not used anymore by the Desktop DLL.What
Remove package reference
ReactWindows.OpenSSL.StdCall.Staticfor React.Windows.Desktop andReact.Windows.Desktop.DLL.Microsoft Reviewers: Open in CodeFlow