Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flyout's Stylesheet import #13476

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Conversation

TatianaKapos
Copy link
Contributor

@TatianaKapos TatianaKapos commented Jul 19, 2024

Description

Resolves #13475.
Will need to backport this to 0.75

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

While verifying Gallery on 0.75-preview1, noticed that Flyout not longer launches. I'm surprised this made it through our testing without being caught, should add to a test for this case.

Testing

Tested locally

Changelog

no

Add a brief summary of the change to use in the release notes for the next release.

Microsoft Reviewers: Open in CodeFlow

@TatianaKapos TatianaKapos requested a review from a team as a code owner July 19, 2024 21:58
@Yajur-Grover
Copy link
Contributor

Yajur-Grover commented Jul 19, 2024

We should make a tracking issue to try and modify the E2E tests to capture this scenario.
This is the issue tracking adding tests for launching a Flyout/Popup which would capture this scenario in the future: #11102.

@TatianaKapos TatianaKapos merged commit 7992021 into microsoft:main Jul 23, 2024
57 checks passed
@TatianaKapos TatianaKapos deleted the tk-fixflyout branch July 23, 2024 18:20
TatianaKapos added a commit to TatianaKapos/react-native-windows that referenced this pull request Jul 23, 2024
TatianaKapos added a commit that referenced this pull request Jul 24, 2024
* Backport #13476 - Fix Flyout's Stylesheet import

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flyout no longer launches
2 participants