Don't override Hermes platform for ARM64EC #13490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
approved these changes
Jul 24, 2024
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jul 25, 2024
* Don't override Hermes platform for ARM64EC * Change files * Upgrade Hermes to 0.1.23 * Update packages.lock
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jul 25, 2024
* Don't override Hermes platform for ARM64EC * Change files * Upgrade Hermes to 0.1.23 * Update packages.lock
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jul 25, 2024
* Don't override Hermes platform for ARM64EC * Change files * Upgrade Hermes to 0.1.23 * Update packages.lock
JunielKatarn
added a commit
that referenced
this pull request
Jul 26, 2024
JunielKatarn
added a commit
that referenced
this pull request
Jul 26, 2024
JunielKatarn
added a commit
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Have ARM64EC react-native-win32.dll consume ARM64EC Hermes.
Type of Change
Why
Loading x64 dependencies on ARM64EC processes has a performance overhead.
What
Stop overriding the
HermesPlatformMSBuild property when building under ARM64EC.Hermes should now provide a native ARM64EC variant.
Microsoft Reviewers: Open in CodeFlow